Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init: setup unity and code confg file for builtin library #297

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

LinjingZhang
Copy link
Collaborator

  • add unity setup in CAN lib, include makefiles take unity from local install path
  • code check files such like cpp checheck, clang-tidy and so on
  • format CAN lib with clang-format

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Init unity setup and code check configuration

Related Issue
/DESMAKERS-3927

Context
Just starting point, no need to merge now

- add unity setup in CAN lib, include makefiles take unity from local install path
- code check files such like cpp checheck, clang-tidy and so on
- format CAN lib with clang-format
@LinjingZhang
Copy link
Collaborator Author

Temporary documentation: IFX_CONTRIBUTING.md

@ederjc ederjc removed their request for review October 8, 2024 12:27
@LinjingZhang LinjingZhang requested review from bargfred and removed request for OlafFilies October 14, 2024 06:29
libraries/CAN/cppcheck.checkers Outdated Show resolved Hide resolved
config/cppcheck/misra_local.py Outdated Show resolved Hide resolved
libraries/CAN/Makefile.codechecks.mk Outdated Show resolved Hide resolved
libraries/CAN/src/CANXMC.cpp Outdated Show resolved Hide resolved
libraries/CAN/src/CANXMC.cpp Show resolved Hide resolved
libraries/CAN/src/CANXMC.cpp Show resolved Hide resolved
libraries/CAN/src/CANXMC.cpp Show resolved Hide resolved
libraries/CAN/src/CANXMC.cpp Show resolved Hide resolved
config/arduinoLibraryTemplate/library.properties Outdated Show resolved Hide resolved
config/clang-format/.clang-format Show resolved Hide resolved
libraries/CAN/src/CANXMC.cpp Show resolved Hide resolved
libraries/CAN/src/CANXMC.cpp Outdated Show resolved Hide resolved
@@ -0,0 +1,27 @@
// std includes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was generated by me, right ? Is it still needed ?

@@ -0,0 +1,44 @@
// std includes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may even merge the related files under arduino, features and corelibs as everything is taking place in the same environment. This was different for the 3D magnetic library : the tests had to be independent of of Arduino functionality in order to be reusable for MTB. But here separating the directories does not make sense, all is taking place in Arduino.
This will also allow you to better test the code currently in the arduino/corelibs directory.

@@ -0,0 +1,78 @@
// std includes

// test includes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File no longer required ?

@LinjingZhang
Copy link
Collaborator Author

LinjingZhang commented Oct 22, 2024

image

pingpong v2 for CAN, with flexible size and loop
Need to change the folder structure regarding review comments and adding Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants